Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vue shims to use DefineComponent #223

Closed
wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

This is a repro to showcase the issue introduced by vuejs/core@6aa2256

As soon as we start using the proper shim for SFC (the one used by the CLI) then we see the issue.

@cexbrayat
Copy link
Member Author

Note that changing the shim to DefineComponent<any, any, any> makes everything green again (I opened a PR in the CLI repo if that's the way to go vuejs/vue-cli#5975).

@lmiller1990
Copy link
Member

Should we close this in favor of https://github.com/vuejs/vue-test-utils-next/pull/224/files ?

@cexbrayat
Copy link
Member Author

Yes, that was just a repro to get things started 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants