Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stubs): avoid warning on normalized props with Vue v3.4.22 #2413

Merged
merged 1 commit into from Apr 16, 2024

Conversation

cexbrayat
Copy link
Member

Fixes #2411

We can "trick" the warning introduced in Vue v3.4.22 (See vuejs/core@7ccd453) by using an array of strings instead of a string (as the new check allows functions and arrays, but not strings). This does not affect the rendering of the stub, and still displays [Function], so it should not impact the existing tests.

Fixes vuejs#2411

We can "trick" the warning introduced in Vue v3.4.22 (See vuejs/core@7ccd453)
by using an array of strings instead of a string (as the new check allows functions and arrays, but not strings).
This does not affect the rendering of the stub, and still displays `[Function]`, so it should not impact the existing tests.
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit a2c491b
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/661e3a9b498fc90008633f42
😎 Deploy Preview https://deploy-preview-2413--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@freakzlike freakzlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything. Nice fix

@cexbrayat cexbrayat merged commit 05d9745 into vuejs:main Apr 16, 2024
6 checks passed
@cexbrayat cexbrayat deleted the fix/2411 branch April 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Stubs broken in vue@3.4.22
2 participants