fix: set global provides before running vue plugins #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cexbrayat
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
Hi @danielroe
That looks reasonable to me, thanks for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to have some push-back on this, but encountered a situation in
@nuxt/test-utilswhere we set default 'provides' but would like the user to be able to register their own plugins to override these.Reordering the provides before the plugins seems like a reasonable way to do this, but happy for other ideas, or to try to tackle this downstream instead if you don't like the change or it breaks something.
resolves nuxt/test-utils#828