feat: add options.attachTo #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I think we need to reset the body for the majority of cases (except this one). VTU beta did not mount on the DOM by default. Only with this option. Vue 3 doesn't seem to be able to Code seems fine, I will play with it a bit before merging. thanks for porting this! |
lmiller1990
approved these changes
Apr 21, 2020
src/mount.ts
Outdated
| @@ -26,6 +26,7 @@ import { | |||
| MOUNT_PARENT_NAME | |||
| } from './constants' | |||
| import { stubComponents } from './stubs' | |||
| import { isString } from './utils' | |||
There was a problem hiding this comment.
Maybe we can use isString from lodash. You would need to update the rollup.config.js too.
# Conflicts: # rollup.config.js # src/mount.ts # src/utils.ts
|
Seems good! Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests from here
SSR test not ported, because I'm not sure how to test it.
Note
The reset of the document body now only happens if you don't pass a child, maybe this should be passed as an option?