fix(find): allow finding root without name

[xanf]

Pretty self-describing, I hope :)

[lmiller1990]

One comment. Also just to confirm my understanding here, the way this works is we create a stub (which is not really a stub, just maps to itself) to be able to search via constructor?

[lmiller1990]

This test is not relevant anymore, is it? It was testing for the missing behavior which you implemented.

[xanf]

It is still relevant - we still should throw getComponent if we were unable to find component without name. It just updated to reflect changes in this PR - previously we were searching for compA inside compA - and it throws (not the case anymore), now we search for compA inside compB and it also throws (which is what this test about - about throwing, not about matching root)

[xanf]

One comment. Also just to confirm my understanding here, the way this works is we create a stub (which is not really a stub, just maps to itself) to be able to search via constructor?

Sometimes (when the component is created via options API or is a functional component) - instead of mounting the component we're providing we're making its "clone" (this is required to modify mixins field for data() and components for #845). Luckily we already have logic in place "when you're searching for component X - match componentY" which is used to allow finding stubs by original component object. This PR simply reuses this logic for root component (I'm happy that we did not introduce MORE workarounds here) :)

[lmiller1990]

Great - just need to resolve the conflict.

One all these are merged up, let's do a release.

[xanf]

@lmiller1990 Sure, I will arrange this today

[xanf]

#889 should fix current red master making this green after rebase :)
Will do as soon as #889 will be merged

[xanf]

@lmiller1990 🚀