fix: remove explicit noopener from external links (#871)

vuejs · Jul 13, 2022 · e4c60ab · e4c60ab
1 parent 1ef7a18
commit e4c60ab
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/docs/guide/markdown.md b/docs/guide/markdown.md
@@ -46,7 +46,7 @@ Pages and internal links get generated with the `.html` suffix by default.
 
 ### External Links
 
-Outbound links automatically get `target="_blank" rel="noopener noreferrer"`:
+Outbound links automatically get `target="_blank" rel="noreferrer"`:
 
 - [vuejs.org](https://vuejs.org)
 - [VitePress on GitHub](https://github.com/vuejs/vitepress)

diff --git a/src/client/theme-default/components/VPButton.vue b/src/client/theme-default/components/VPButton.vue
@@ -34,7 +34,7 @@ const component = computed(() => {
     :class="classes"
     :href="href ? normalizeLink(href) : undefined"
     :target="isExternal ? '_blank' : undefined"
-    :rel="isExternal ? 'noopener noreferrer' : undefined"
+    :rel="isExternal ? 'noreferrer' : undefined"
   >
     {{ text }}
   </component>

diff --git a/src/client/theme-default/components/VPLink.vue b/src/client/theme-default/components/VPLink.vue
@@ -19,7 +19,7 @@ const isExternal = computed(() => props.href && EXTERNAL_URL_RE.test(props.href)
     :class="{ link: href }"
     :href="href ? normalizeLink(href) : undefined"
     :target="isExternal ? '_blank' : undefined"
-    :rel="isExternal ? 'noopener noreferrer' : undefined"
+    :rel="isExternal ? 'noreferrer' : undefined"
   >
     <slot />
     <VPIconExternalLink v-if="isExternal && !noIcon" class="icon" />

diff --git a/src/client/theme-default/components/VPSocialLink.vue b/src/client/theme-default/components/VPSocialLink.vue
@@ -32,7 +32,7 @@ const icons = {
     :href="link"
     :title="icon"
     target="_blank"
-    rel="noopener noreferrer"
+    rel="noreferrer"
   >
     <component :is="icons[icon]" class="icon" />
     <span class="visually-hidden">{{ icon }}</span>

diff --git a/src/node/markdown/markdown.ts b/src/node/markdown/markdown.ts
@@ -78,7 +78,7 @@ export const createMarkdownRenderer = async (
       linkPlugin,
       {
         target: '_blank',
-        rel: 'noopener noreferrer',
+        rel: 'noreferrer',
         ...options.externalLinks
       },
       base

diff --git a/src/node/markdownToVue.ts b/src/node/markdownToVue.ts
@@ -83,7 +83,7 @@ export async function createMarkdownToVueRenderFn(
           `\n(!) Found dead link ${c.cyan(url)} in file ${c.white(
             c.dim(file)
           )}\nIf it is intended, you can use:\n    ${c.cyan(
-            `<a href="${url}" target="_blank" rel="noopener noreferrer">${url}</a>`
+            `<a href="${url}" target="_blank" rel="noreferrer">${url}</a>`
           )}`
         )
       )