Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): don't show outline when no header is there #2117

Merged
merged 2 commits into from Mar 21, 2023
Merged

fix(theme): don't show outline when no header is there #2117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca16234
fix(theme): dont show outline when no header is there
brc-dd Mar 21, 2023
a49c8f8
fix ssr
brc-dd Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/client/theme-default/components/VPDocOutlineDropdown.vue
View file
Open in desktop
@@ -1,7 +1,7 @@
<script setup lang="ts">
import { ref } from 'vue'
import { ref, shallowRef } from 'vue'
import { useData } from '../composables/data'
import { getHeaders, resolveTitle } from '../composables/outline'
import { getHeaders, resolveTitle, type MenuItem } from '../composables/outline'
import VPDocOutlineItem from './VPDocOutlineItem.vue'
import { onContentUpdated } from 'vitepress'
import VPIconChevronRight from './icons/VPIconChevronRight.vue'
Expand All @@ -12,16 +12,24 @@ const open = ref(false)
onContentUpdated(() => {
open.value = false
})

const headers = shallowRef<MenuItem[]>([])

onContentUpdated(() => {
headers.value = getHeaders(
frontmatter.value.outline ?? theme.value.outline
)
})
</script>

<template>
<div class="VPDocOutlineDropdown">
<div class="VPDocOutlineDropdown" v-if="headers.length > 0">
<button @click="open = !open" :class="{ open }">
{{ resolveTitle(theme) }}
<VPIconChevronRight class="icon" />
</button>
<div class="items" v-if="open">
<VPDocOutlineItem :headers="getHeaders(frontmatter.outline ?? theme.outline)" />
<VPDocOutlineItem :headers="headers" />
</div>
</div>
</template>
Expand Down
19 changes: 15 additions & 4 deletions src/client/theme-default/components/VPLocalNavOutlineDropdown.vue
View file
Open in desktop
@@ -1,7 +1,7 @@
<script setup lang="ts">
import { ref, nextTick } from 'vue'
import { ref, nextTick, shallowRef } from 'vue'
import { useData } from '../composables/data'
import { getHeaders, resolveTitle } from '../composables/outline'
import { getHeaders, resolveTitle, type MenuItem } from '../composables/outline'
import VPDocOutlineItem from './VPDocOutlineItem.vue'
import { onContentUpdated } from 'vitepress'
import VPIconChevronRight from './icons/VPIconChevronRight.vue'
Expand Down Expand Up @@ -36,14 +36,25 @@ function scrollToTop() {
open.value = false
window.scrollTo({ top: 0, left: 0, behavior: 'smooth' })
}

const headers = shallowRef<MenuItem[]>([])

onContentUpdated(() => {
headers.value = getHeaders(
frontmatter.value.outline ?? theme.value.outline
)
})
</script>

<template>
<div class="VPLocalNavOutlineDropdown" :style="{ '--vp-vh': vh + 'px' }">
<button @click="toggle" :class="{ open }">
<button @click="toggle" :class="{ open }" v-if="headers.length > 0">
{{ resolveTitle(theme) }}
<VPIconChevronRight class="icon" />
</button>
<button @click="scrollToTop" v-else>
{{ theme.returnToTopLabel || 'Return to top' }}
</button>
<Transition name="flyout">
<div v-if="open"
ref="items"
Expand All @@ -53,7 +64,7 @@ function scrollToTop() {
<a class="top-link" href="#" @click="scrollToTop">
{{ theme.returnToTopLabel || 'Return to top' }}
</a>
<VPDocOutlineItem :headers="getHeaders(frontmatter.outline ?? theme.outline)" />
<VPDocOutlineItem :headers="headers" />
</div>
</Transition>
</div>
Expand Down