Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): use locale lang instead of navigator lang for dates #2118

Merged
merged 2 commits into from Mar 21, 2023
Merged

fix(theme): use locale lang instead of navigator lang for dates #2118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e711304
fix(theme): use locale lang instead of navigator lang for dates
brc-dd Mar 21, 2023
17789cc
fix hydration error
brc-dd Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/client/theme-default/components/VPDocFooterLastUpdated.vue
View file
Open in desktop
Expand Up @@ -2,18 +2,17 @@
import { ref, computed, watchEffect, onMounted } from 'vue'
import { useData } from '../composables/data'

const { theme, page } = useData()
const { theme, page, lang } = useData()

const date = computed(() => new Date(page.value.lastUpdated!))
const isoDatetime = computed(() => date.value.toISOString())
const datetime = ref('')

// set time on mounted hook because the locale string might be different
// based on end user and will lead to potential hydration mismatch if
// calculated at build time
// set time on mounted hook to avoid hydration mismatch due to
// potential differences in timezones of the server and clients
onMounted(() => {
watchEffect(() => {
datetime.value = date.value.toLocaleString(window.navigator.language)
datetime.value = date.value.toLocaleString(lang.value)
})
})
</script>
Expand Down