New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): display file name when rendering fails #2373
base: main
Are you sure you want to change the base?
Conversation
Can you provide me a minimal reproducible example where the error stack has no mention of corresponding file? |
I made this PR a few months ago, so I can't remember the exact issue I had. I believe that I made a typo and tried to acccess a property of an undefined variable. This should repro:
|
I think you misunderstand. This shows the file name of the markdown file where the error occurred, not the file name of the script in which the error occurred. |
I'm kinda stuck with using my own patch for debugging until this is merged. |
7ad4a4e
to
f0d3082
Compare
But the name of markdown file is easily inferable from the script name. an error in |
This small patch will save many people a LOT of time debugging. It would have saved me at least an hour.
I can't imagine that it's intentional that there is no information regarding which file caused rendering to fail, so that's why I'm calling this a fix.