Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make users install vue too #533

Merged
merged 2 commits into from Jun 14, 2022
Merged

docs: make users install vue too #533

merged 2 commits into from Jun 14, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Feb 14, 2022

fixes #531

@yyx990803 yyx990803 added the docs label Feb 22, 2022
@kiaking kiaking added docs Improvements or additions to documentation and removed docs labels Apr 6, 2022
@brc-dd
Copy link
Member Author

brc-dd commented Jun 3, 2022

Updated the branch.

Context: Vue needs to be explicitly installed when using Yarn v2/v3.

@kiaking
Copy link
Member

kiaking commented Jun 6, 2022

Thanks! Should we change package manager to be npm 🤔 And then add info box or something to mention about yarn 2/3. We're using pnpm here but... it should work in npm without probrems too so 👀

@brc-dd
Copy link
Member Author

brc-dd commented Jun 6, 2022

If we merge #707, then also users will need to add vue explicitly (in pnpm/npm too).

@kiaking kiaking merged commit 6eda63e into vuejs:main Jun 14, 2022
D3SOX added a commit to D3SOX/arch-guide that referenced this pull request Jun 14, 2022
@brc-dd brc-dd deleted the patch-12 branch June 17, 2022 07:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Improvements or additions to documentation
Projects
None yet
3 participants