fix afterInvoke/onCreateComplete callbacks in Migrator (#5062)

closes #4837
vuejs · Jan 13, 2020 · 42bd09f · 42bd09f
1 parent 1c269d2
commit 42bd09f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/@vue/cli/lib/Migrator.js b/packages/@vue/cli/lib/Migrator.js
@@ -6,14 +6,14 @@ module.exports = class Migrator extends Generator {
     plugin,
 
     pkg = {},
-    completeCbs = [],
+    afterInvokeCbs = [],
     files = {},
     invoking = false
   } = {}) {
     super(context, {
       pkg,
       plugins: [],
-      completeCbs,
+      afterInvokeCbs,
       files,
       invoking
     })

diff --git a/packages/@vue/cli/lib/Upgrader.js b/packages/@vue/cli/lib/Upgrader.js
@@ -118,13 +118,13 @@ module.exports = class Upgrader {
       installed: options.installed
     }
 
-    const createCompleteCbs = []
+    const afterInvokeCbs = []
     const migrator = new Migrator(this.context, {
       plugin: plugin,
 
       pkg: this.pkg,
       files: await readFiles(this.context),
-      completeCbs: createCompleteCbs,
+      afterInvokeCbs,
       invoking: true
     })
 
@@ -146,9 +146,9 @@ module.exports = class Upgrader {
       await this.pm.install()
     }
 
-    if (createCompleteCbs.length) {
+    if (afterInvokeCbs.length) {
       logWithSpinner('⚓', `Running completion hooks...`)
-      for (const cb of createCompleteCbs) {
+      for (const cb of afterInvokeCbs) {
         await cb()
       }
       stopSpinner()