Skip to content

Commit

Permalink
fix: configuration should be synced regardless of $_init
Browse files Browse the repository at this point in the history
fixes #2521
fixes #2522
  • Loading branch information
sodatea committed Sep 17, 2018
1 parent 6b825de commit b1b04b8
Showing 1 changed file with 0 additions and 2 deletions.
Expand Up @@ -107,15 +107,13 @@ export default {
id: this.id
}
},
manual: true,
async result ({ data, loading }) {
if (!this.$_init && !loading && data && data.configuration) {
this.$_init = true
this.tabsHaveChanges = data.configuration.tabs.reduce((obj, tab) => {
obj[tab.id] = false
return obj
}, {})
this.configuration = data.configuration
await this.$nextTick()
this.currentTab = data.configuration.tabs[0].id
}
Expand Down

3 comments on commit b1b04b8

@Akryum
Copy link
Member

@Akryum Akryum commented on b1b04b8 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have beaten me for it 😹

@sodatea
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought you might not have the time to investigate it.

😹And I'm actually testing my local git setup by doing this commit (look at the weird timestamp).

@Akryum
Copy link
Member

@Akryum Akryum commented on b1b04b8 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I first looked at the issue I though "I should revert manual mode on this query" but I was working on devtools so snoozed this but then you did exactly that 😻

Please sign in to comment.