Skip to content

Commit

Permalink
fix(e2e-nightwatch): check for correct flag name (#5016)
Browse files Browse the repository at this point in the history
* fix(e2e-nightwatch): check for correct flag name

flag is documented as `--use-selenium` but we checked for `args['with-selenium']`
fix #5015

* test(e2e-nightwatch): selenium test
uses correct flag now
  • Loading branch information
LinusBorg authored and sodatea committed Jan 3, 2020
1 parent 4087220 commit bc2dc96
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Expand Up @@ -69,7 +69,7 @@ describe('nightwatch e2e plugin', () => {
})

test('should run single test with custom nightwatch.json and selenium server', async () => {
await project.run(`vue-cli-service test:e2e --headless --with-selenium -t tests/e2e/specs/test.js`)
await project.run(`vue-cli-service test:e2e --headless --use-selenium -t tests/e2e/specs/test.js`)
let results = await project.read('test_results.json')
results = JSON.parse(results)

Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-plugin-e2e-nightwatch/index.js
Expand Up @@ -65,7 +65,7 @@ module.exports = (api, options) => {
rawArgs.push('--env', 'chrome')
}

if (args['with-selenium']) {
if (args['use-selenium']) {
process.env.VUE_NIGHTWATCH_USE_SELENIUM = '1'
}

Expand Down

0 comments on commit bc2dc96

Please sign in to comment.