refactor: use the title option in the html template, instead… (#5060)

closes #5056
vuejs · Jan 13, 2020 · bc3e4af · bc3e4af
1 parent 9ac7ce5
commit bc3e4af
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/@vue/cli-service/generator/template/public/index.html b/packages/@vue/cli-service/generator/template/public/index.html
@@ -5,11 +5,11 @@
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width,initial-scale=1.0">
     <link rel="icon" href="<%%= BASE_URL %%>favicon.ico">
-    <title><%= rootOptions.projectName %></title>
+    <title><%%= htmlWebpackPlugin.options.title %%></title>
   </head>
   <body>
     <noscript>
-      <strong>We're sorry but <%= rootOptions.projectName %> doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
+      <strong>We're sorry but <%%= htmlWebpackPlugin.options.title %%> doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
     </noscript>
     <div id="app"></div>
     <!-- built files will be auto injected -->

diff --git a/packages/@vue/cli-service/lib/config/app.js b/packages/@vue/cli-service/lib/config/app.js
@@ -84,6 +84,7 @@ module.exports = (api, options) => {
     }
 
     const htmlOptions = {
+      title: api.service.pkg.name,
       templateParameters: (compilation, assets, pluginOptions) => {
         // enhance html-webpack-plugin's built in template params
         let stats