Add 3rd option to lintOnSave to support 'default' behaviour (fix #3552)
#3572
+41
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous singluar flag 'error'
LinusBorg
changed the title
lintOnSave to support 'default' behaviour
LinusBorg
changed the title
lintOnSave to support 'default' behaviourlintOnSave to support 'default' behaviour (fix #3552)
|
Oh i just found some mistakes in the docs changes. Don't merge this yet! |
add missing 'warning' value.
|
Should be good now. |
haoqunjiang
requested changes
Mar 6, 2019
There was a problem hiding this comment.
Did you accidentally turn on some editor plugin to aggressively format the code?
I saw several unnecessary code style changes:
- extra spaces before
::: - extra trailing commas in the code examples
- missing indentations in
packages/@vue/cli-plugin-eslint/index.js
etc.
This also happens in #3523
|
Yeah sorry, I'll undo those. |
haoqunjiang
approved these changes
Mar 8, 2019
|
Thanks for cleaning up the remaining formatting issue :/ I've ensured that my editor won't do that again. |
haoqunjiang
added a commit
to haoqunjiang/vue-cli
that referenced
this pull request
May 10, 2019
BREAKING CHANGE: See vuejs#3572
haoqunjiang
added a commit
that referenced
this pull request
May 14, 2019
BREAKING CHANGE: See #3572
ZanderOlidan
pushed a commit
to ZanderOlidan/vue-cli-service-chalkfix
that referenced
this pull request
Feb 5, 2024
BREAKING CHANGE: See vuejs/vue-cli#3572
ZanderOlidan
pushed a commit
to ZanderOlidan/vue-cli-service-chalkfix
that referenced
this pull request
Feb 5, 2024
BREAKING CHANGE: See vuejs/vue-cli#3572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when enabled, lintOnSave either emits everything as warnings (
true), or everything as errors ('error').This PR adds a another option,
'default', which will do what most people would expect: emit errors as errors, and warnings as warnings.Explanation of new set of options:
"default": emit warnings and warnings and errors as errors (the new behaviour)"warning": emit everything as warnings (avoid errors to pop up in overlay during development)"error": emit everything as errorstrue: same as"warning"(also same as current behavior so it doesn't have to be breaking, can be deprecated in next major)close #3552