Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wc entry accepts multiple file patterns splited by ',' #3886

Merged
merged 1 commit into from Mar 21, 2020

Conversation

manico
Copy link
Contributor

@manico manico commented Apr 25, 2019

This PR allows globby to get files from multiple different directories by using comma separated list of file patterns. This way we can also list specific components.

Examples:

vue-cli-service build --target wc --name myprefix src/components/core*.vue,src/components/basic*.vue

vue-cli-service build --target wc --name myprefix src/components/myFirst.vue,src/components/mySecond.vue

@manico manico changed the title Fix wc entry to allow multiple files Fix wc entry to allow multiple file patterns Apr 25, 2019
@ca5839e6
Copy link

ca5839e6 commented Feb 21, 2020

Hey it's a major enhancement why no body merge this? lib also need this!

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the late review!

@sodatea sodatea merged commit db64c5b into vuejs:dev Mar 21, 2020
@sodatea sodatea changed the title Fix wc entry to allow multiple file patterns feat: wc entry accepts multiple file patterns splited by ',' Mar 21, 2020
@theboredfish
Copy link

any particular reason this wasn't also applied to 'lib' components?
need a way of independently compiling so that, if one failed, the rest would continue, so chunks and a common entry file isn't really an option for me i don't think :-/

@YamiOdymel
Copy link

Leaving a note here, remember to use the ' single quote to quote your path to get everything right.

Error (notice missing quotes)
npx vue-cli-service build --target wc --name companyname ./src/components/*.vue

Success
npx vue-cli-service build --target wc --name companyname './src/components/*.vue'

Source: #2024 --name must contain a hyphen when building a single web component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants