Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-service): fix duplicate webpack-dev-server/client #4843

Closed
wants to merge 1 commit into from

Conversation

githoniel
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

WebpackDevServer will add client scripts to entry by default, result in duplicate webpack-dev-server/client.

@githoniel githoniel marked this pull request as ready for review November 14, 2019 02:17
@pksunkara
Copy link
Contributor

Can you describe a bit about why this is needed?

@githoniel
Copy link
Contributor Author

@pksunkara
see https://github.com/webpack/webpack-dev-server/blob/v3.9.0/lib/utils/addEntries.js#L19

webpack-dev-server will add dev-entry-client and hot-entry when options.inline = true
in 3.9.0. Since vue-cli will add dev-entry-client and hot-entry manually, I set options.inline = false to avoid duplicate.

@sodatea
Copy link
Member

sodatea commented Sep 4, 2020

inline: false only switches to iframe mode. The correct fix is to set injectClient: false, see #5069. It's been fixed in v4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants