Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e-nightwatch): check for correct flag name #5016

Merged
merged 2 commits into from Jan 3, 2020
Merged

fix(e2e-nightwatch): check for correct flag name #5016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0447c40
fix(e2e-nightwatch): check for correct flag name
LinusBorg Jan 1, 2020
10333df
test(e2e-nightwatch): selenium test
LinusBorg Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js
View file
Open in desktop
Expand Up @@ -69,7 +69,7 @@ describe('nightwatch e2e plugin', () => {
})

test('should run single test with custom nightwatch.json and selenium server', async () => {
await project.run(`vue-cli-service test:e2e --headless --with-selenium -t tests/e2e/specs/test.js`)
await project.run(`vue-cli-service test:e2e --headless --use-selenium -t tests/e2e/specs/test.js`)
let results = await project.read('test_results.json')
results = JSON.parse(results)

Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-plugin-e2e-nightwatch/index.js
View file
Open in desktop
Expand Up @@ -65,7 +65,7 @@ module.exports = (api, options) => {
rawArgs.push('--env', 'chrome')
}

if (args['with-selenium']) {
if (args['use-selenium']) {
process.env.VUE_NIGHTWATCH_USE_SELENIUM = '1'
}

Expand Down