fix: should infer package manager from config if there's no lockfile in the project #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckfile in the project
Akryum
reviewed
Feb 6, 2020
| @@ -88,8 +89,17 @@ class PackageManager { | |||
| if (forcePackageManager) { | |||
There was a problem hiding this comment.
How do we force the package manager?
There was a problem hiding this comment.
The -m / --packageManager option of vue create. Maybe we should add this option for vue add and vue invoke too?
Akryum
reviewed
Feb 6, 2020
| return true | ||
| } | ||
|
|
||
| const lockFile = path.join(cwd, 'package-lock.json') |
There was a problem hiding this comment.
Yeah that makes more sense.
mactanxin
pushed a commit
to mactanxin/vue-cli
that referenced
this pull request
Feb 11, 2020
…in the project (vuejs#5150) * fix: should infer package manager from config if there's no lockfile in the project * fixup! fix: should infer package manager from config if there's no lockfile in the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed monorepo use cases.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: