fix "Vue packages version mismatch" error caused by other global packages #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… packages closes vuejs#5161 The root cause of such issues: `vue-jscodeshift-adapter` requires `vue-template-compiler`. `vue-template-compiler` tries to require the `vue` package and check its version on startup. Normally, there's no `vue` package in the dependency tree of `@vue/cli`, so this check will just skip. But if the user has installed some other global package that depend on `vue`, and hoists it to the root `node_modules`, `vue-template-compiler` would successfully require it and check against that `vue` version, which sometimes may be outdated, thus failing the bootstrap process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5161
The root cause of such issues:
vue-jscodeshift-adapterrequiresvue-template-compiler.vue-template-compilertries to require thevuepackage and checkits version on startup.
Normally, there's no
vuepackage in the dependency tree of@vue/cli,so this check will just skip.
But if the user has installed some other global package that depend on
vue, and hoists it to the rootnode_modules,vue-template-compilerwould successfully require it and check against that
vueversion,which sometimes may be outdated, thus failing the bootstrap process.
So by adding a "vue" dependency to the
@vue/clipackage, we can make sure thevue-template-compilerpackage in the dependency tree can always get the up-to-date version number and pass the test.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: