-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat: use @vue/compiler-sfc as a compiler for TS if available #5170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a413e6
to
e162f6e
Compare
I think we can just add a file that shims the |
All it needs is a path to a file that exports the |
e2627da
to
2b2f03a
Compare
@sodatea I updated the PR based on your idea.
We should now be able to remove |
When vuejs/vue-cli#5170 lands in the CLI, we should be able to remove `vue-template-compiler` from the devDependencies. Fixes vuejs#5
2b2f03a
to
7dd72b5
Compare
@sodatea I updated the PR with your feedback:
|
The `fork-ts-checker-webpack-plugin` is using `vue-template-compiler` by default, and this compiler is not the correct one to pick for vue-next. This commit tries to load `@vue/compiler-sfc` and falls back to `vue-template-compiler` if it does not find it.
7dd72b5
to
4e64a09
Compare
Update: I'll let you decide but #5172 is probably a better alternative. See vuejs/vue-cli-plugin-vue-next#5 for more context
The
fork-ts-checker-webpack-plugin
is usingvue-template-compiler
by default, and this compiler is not the correct one to pick for vue-next. This commit tries to load@vue/compiler-sfc
and falls back tovue-template-compiler
if it does not find it.It also bumps the
fork-ts-checker-webpack-plugin
to use v3.1.3What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: