Fix: stop ignoring --config-file cypress option #5580
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
requested changes
Jun 18, 2020
This fixes an issue with the implementation of `removeArg()` whereby calling `removeArg(args, "config")` removed argument "--config-file" if provided This commit fixes this by ensuring that calling `removeArg(args, "config")` removes `--config` without removing `--config-file`.
|
@sodatea Test fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we always call
removeArg(rawArgs, 'config'), and since thematchREmatches--configas well as--config-file, we end up ignoring the--config-fileoption if it is provided (e.g.--config-file my-config.json).This commit fixes this by ensuring that calling
removeArg('config')removes--configwithout removing--config-file.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: