Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unit-jest, unit-mocha): generate passing tests when bare option is used with router enabled (#3544) #5591

Merged
merged 2 commits into from Sep 7, 2020

Conversation

IwalkAlone
Copy link
Contributor

Fixes: #3544

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Could you please fix the merge conflicts so that we can merge the PR?

@IwalkAlone
Copy link
Contributor Author

Looks good to me.

Could you please fix the merge conflicts so that we can merge the PR?

@sodatea Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue cli -b with router generates a test that fails
2 participants