Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix support for some legacy registry servers #5609

Merged
merged 1 commit into from Jun 24, 2020

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Jun 23, 2020

Some registry servers do not recognize application/vnd.npm.install-v1+json
in the Accept header, so here we add application/json as fallback.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Some registry servers do not recognize `application/vnd.npm.install-v1+json`
in the Accept header, so here we add `application/json` as fallback.
@sodatea
Copy link
Member Author

sodatea commented Jun 23, 2020

I've tested with verdaccio and the latest version of Sonatype Nexus3, both recognized the application/vnd.npm.install-v1+json header. But there may be some legacy versions doesn't support it, as reported in this issue: #5411 (comment)

@sodatea sodatea merged commit 09cdf51 into vuejs:dev Jun 24, 2020
@sodatea sodatea deleted the fix-metadata-json branch June 24, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant