Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] common misspelling errors #5694

Merged
merged 2 commits into from Aug 9, 2020
Merged

Conversation

Necmttn
Copy link
Contributor

@Necmttn Necmttn commented Jul 18, 2020

https://github.com/vuejs/vue-cli/blob/master/docs/guide/deployment.md#L133: corrected "wih" to "with"
https://github.com/vuejs/vue-cli/blob/master/docs/dev-guide/ui-localization.md#L5: corrected "synchronisation" to "synchronization"
https://github.com/vuejs/vue-cli/blob/master/docs/config/README.md#L260: corrected "explictly" to "explicitly"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli-service/lib/util/resolveLoaderError.js#L23: corrected "defualt" to "default"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli-service/lib/config/terserOptions.js#L22: corrected "noticable" to "noticeable"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/lib/globals-generated.js#L2: corrected "inpsect" to "inspect"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli-plugin-typescript/__tests__/tsPluginTSLint.spec.js#L109: corrected "behaviour" to "behavior"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli/lib/util/confirmIfGitDirty.js#L24: corrected "uncommited" to "uncommitted"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli/__tests__/invoke.spec.js#L153: corrected "uncommited" to "uncommitted"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli/lib/GeneratorAPI.js#L230: corrected "compatiblity" to "compatibility"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/babel-preset-app/index.js#L98: corrected "envrionment" to "environment"
https://github.com/vuejs/vue-cli/blob/master/packages/@vue/cli-plugin-eslint/generator/index.js#L46: corrected "extentions" to "extensions"
https://github.com/vuejs/vue-cli/blob/master/CHANGELOG.md#L1678: corrected "behaviour" to "behavior"
https://github.com/vuejs/vue-cli/blob/master/CHANGELOG.md#L3275: corrected "detials" to "details"
https://github.com/vuejs/vue-cli/blob/master/CHANGELOG.md#L4165: corrected "casuing" to "causing"
https://github.com/vuejs/vue-cli/blob/master/CHANGELOG.md#L4241: corrected "dahsboard" to "dashboard"
@@ -43,7 +43,7 @@ module.exports = (api, { config, lintOn = [] }, _, invoking) => {
pkg.gitHooks = {
'pre-commit': 'lint-staged'
}
const extentions = require('../eslintOptions').extensions(api)
const extensions = require('../eslintOptions').extensions(api)
.map(ext => ext.replace(/^\./, '')) // remove the leading `.`
pkg['lint-staged'] = {
[`*.{${extentions.join(',')}}`]: ['vue-cli-service lint', 'git add']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But you need to fix this line too.

@sodatea sodatea merged commit 5baec1f into vuejs:dev Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants