Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shouldn't remove attribute quotes in HTML #5899

Merged
merged 2 commits into from Sep 27, 2020

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Sep 24, 2020

Fixes #5896

It's also recommended to enable this option with caution in the
html-minifier documentation:
http://perfectionkills.com/experimenting-with-html-minifier/#remove_attribute_quotes

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Fixes vuejs#5896

It's also recommended to enable this option with caution in the
html-minifier documentation:
<http://perfectionkills.com/experimenting-with-html-minifier/#remove_attribute_quotes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web app manifest injection in PWA plugin missing quotes
1 participant