Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: narrow the eslint peer dep version range, avoiding npm 7 error #5962

Merged
merged 1 commit into from Oct 15, 2020

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Oct 14, 2020

v4 does not support eslint 7

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@sodatea sodatea merged commit d77fa6a into vuejs:v4 Oct 15, 2020
@sodatea sodatea deleted the fix-eslint-peer-version branch October 15, 2020 07:24
@vadjs
Copy link

vadjs commented Apr 13, 2021

@sodatea this PR prevents usage of eslint v7.0.0+ in any vue project entirely. It's breaking change.
Please, revert this PR.

@sodatea
Copy link
Member Author

sodatea commented Apr 13, 2021

Even if I reverted it, Vue CLI v4 cannot support ESLint v7.

@sodatea
Copy link
Member Author

sodatea commented Apr 13, 2021

It's eslint-loader v2.x cannot support ESLint 7 https://github.com/webpack-contrib/eslint-loader/blob/v2.2.1/package.json
And we can't upgrade it without bumping the major version.

So please use @vue/cli-plugin-eslint v5 for ESLint 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants