Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support basic auth for npm registry access #6207

Merged
merged 1 commit into from Jan 14, 2021

Conversation

bodograumann
Copy link
Contributor

When username and password are configured in the .npmrc for the
respective scope, use basic auth when getting package metadate from the
npm registry.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Cf. #6206

@bodograumann
Copy link
Contributor Author

This can also be cherry-picked on v4.

@bodograumann
Copy link
Contributor Author

What is the problem and why can I not see the test result myself?

@fangbinwei
Copy link
Collaborator

Maybe you should log in circleci first

I can see some errors like below
image

When username and password are configured in the .npmrc for the
respective scope, use basic auth when getting package metadate from the
npm registry.
@bodograumann
Copy link
Contributor Author

@fangbinwei Thanks for the paste.
I don’t have a circlici account and when I try to create one, it asks for write-permissions to my github account.
So that is not an option for me.

@sodatea sodatea merged commit 2503ba6 into vuejs:dev Jan 14, 2021
@sodatea sodatea changed the title fix: use basic auth for npm registry access fix: support basic auth for npm registry access Jan 14, 2021
sodatea pushed a commit that referenced this pull request Jan 22, 2021
When username and password are configured in the .npmrc for the
respective scope, use basic auth when getting package metadata from the
npm registry.

Closes #6206
This was referenced Mar 16, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants