feat: use eslint v8 #6749
Closed
feat: use eslint v8 #6749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
force-pushed
the
feat/support-eslint-v8
branch
from
5041c4a
to
0181075
Compare
sodatea
reviewed
Oct 13, 2021
| @@ -32,6 +32,6 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@vue/cli-service": "^3.0.0 || ^4.0.0 || ^5.0.0-0", | |||
| "eslint": ">=7.5.0" | |||
| "eslint": "^8.0.0" | |||
There was a problem hiding this comment.
I think this is not necessary now that the plugin is still compatible with ESLint 7.
There was a problem hiding this comment.
I can revert no problem. I was wondering: how to test that there is no issue with eslint v7? Duplicate all tests for v7 and v8? Or do we just assume it works?
There was a problem hiding this comment.
For now, it should work, because we didn't touch any code in index.js or lint.js.
In the future, yes, a dedicated test setup for ESlint 7 is needed.
There was a problem hiding this comment.
All right let's keep >=7.5.0 for now then.
PR updated.
cexbrayat
force-pushed
the
feat/support-eslint-v8
branch
from
0181075
to
a3e3ac2
Compare
This was referenced Oct 13, 2021
cexbrayat
force-pushed
the
feat/support-eslint-v8
branch
5 times, most recently
from
b0b07ab
to
2e85e80
Compare
cexbrayat
force-pushed
the
feat/support-eslint-v8
branch
from
2e85e80
to
4f05f65
Compare
Updates the dependencies installed by `@vue/cli-plugin-eslint` to use eslint v8. Plugins are alo updated (when possible) to support eslint v8. Tests have been added to check each configuration.
cexbrayat
force-pushed
the
feat/support-eslint-v8
branch
from
4f05f65
to
50f4594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dependencies installed by
@vue/cli-plugin-eslintto use eslint v8.Plugins are alo updated (when possible) to support eslint v8. Some are not yet updated, and a comment with relevant issue has been added in that case.
Tests have been added to check each configuration, and they all succeed, despite some plugins not yet updated.
Fixes #6740
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: