Add support for scope analysis of <script setup>
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
changed the title
<script setup><script setup>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for scope analysis of
<script setup>.I plan to solve two main problems.
@typescript-eslint/consistent-type-importsBy marking how the variable was used in the template, I'm hoping that the rules that use the scope manager will work.
This change will probably make
no-unused-varsrule work fine even if we remove thevue/script-setup-uses-varsrule.Refs typescript-eslint/typescript-eslint#4508, vuejs/eslint-plugin-vue#1784
I think that by registering the function of the compiler macro globally, it is possible to prevent false positives of the
no-undefrule.It may be possible to deprecate the
'vue/setup-compiler-macros'environment.I think that perhaps these changes will be marked as breaking changes.