Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jest v27 support for vue2-jest #368

Merged
merged 1 commit into from Aug 1, 2021

Conversation

cexbrayat
Copy link
Member

Followup, and quasi identical PR to #343

@lmiller1990 if that looks good, it would be nice to have an alpha release. I think I need it to update the CLI to jest 27 (as it looks like I need to bump Vue 3 and Vue 2 projects at the same time)

@lmiller1990
Copy link
Member

I will do this week, sorry about the delay.

@lmiller1990
Copy link
Member

Alpha release will be in 24-48h! Thanks for the patience.

@lmiller1990 lmiller1990 merged commit 3a0f4fe into vuejs:master Aug 1, 2021
@lmiller1990
Copy link
Member

@cexbrayat just to confirm and make sure we are on the same page, we want this released under vue-jest@27.0.0-alpha.0?

vue2-jest is not available as you pointed out (I think it was you). I need to email npm to get access: https://www.npmjs.com/package/vue2-jest

@cexbrayat
Copy link
Member Author

@lmiller1990 No, I don't think we should release it as vue-jest v27. It would be too confusing in my opinion to have vue-jest v4 for vue 2, v5 for vue 3 and v27 for vue 2 again. If we publish vue-jest v27, it should be the same as vue3-jest v27.

Ideally, it would be nice to have vue2-jest back from NPM, or maybe we could publish this under @vue (@vue/vue2-jest and @vue/vue3-jest?).

@afontcu
Copy link
Member

afontcu commented Aug 2, 2021

Publishing under @vue looks like a valid solution? It makes total sense as it in an official package

@lmiller1990
Copy link
Member

Ok, I will publish it under vue for now (not sure if need any special permissions, I'll give it a shot).

We will need to reach out to npm regarding vue2-jest. I will look into this, although it might need to come from a @vuejs.org email. Let's see how it goes. I'll report back.

@lmiller1990
Copy link
Member

lmiller1990 commented Aug 4, 2021

Ok, I pushed under @vue/vue2-jest! 🎉

I also emailed npm. Anyway, I think we should use @vue namespace moving forward - feels more clean to have all the official packages there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants