Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load TypeScript config from tsconfig package instead of ts-jest #471

Merged
merged 8 commits into from
Aug 15, 2022
Merged

feat: load TypeScript config from tsconfig package instead of ts-jest #471

merged 8 commits into from
Aug 15, 2022
+62 −51

Conversation

nogic1008
Copy link
Collaborator

⚠️This PR contains BREAKING CHANGES!!⚠️

This PR conflicts with #468, so I set as draft.
Resolve #171, #431

Changes

  • Use tsconfig package to load TypeScript config.
  • Remove ts-jest peerDependencies.

Breaking Changes

  • Some tests will break that depend on ts-jest config.
// jest.config.js
module.exports = {
  globals: {
    "ts-jest": {...} // Not loaded during transforming Vue (use tsconfig.json instead)
  }
}

@nogic1008 nogic1008 added bug dependencies Pull requests that update a dependency file labels May 11, 2022
@nogic1008 nogic1008 self-assigned this May 11, 2022
@nogic1008 nogic1008 force-pushed the chore/remove-ts-jest branch from f70abd7 to 83fbdc1 Compare May 17, 2022 07:39
@nogic1008 nogic1008 linked an issue May 17, 2022 that may be closed by this pull request
Fails on lack of ts-jest even though it's optional #431
Closed
@nogic1008 nogic1008 marked this pull request as ready for review May 17, 2022 07:41
@nogic1008 nogic1008 requested a review from lmiller1990 May 17, 2022 07:41
@lmiller1990
Copy link
Member

thanks @nogic1008 - I'm away for 1 week, I can review when I get back.

@Aaron-Pool
Copy link

@lmiller1990 is there a particular reason this wasn't merged? I'd like to upgrade to the new versions of vue-jest, but I'd rather not have to install ts-jest, since I use babel for my typescript transpilations in my test environment

@lmiller1990
Copy link
Member

@Aaron-Pool good question, my main concern was I am not sure how to handle breaking changes, since we now tie ourselves to Jest versions.

I guess it's time to tear of the band-aid, merge this and ship it. I will make this 28.1 - a minor version bump, and include the breaking change in the notes.

@lmiller1990 lmiller1990 merged commit a84eafb into vuejs:master Aug 15, 2022
@lmiller1990
Copy link
Member

It's out. Thanks all, especially @nogic1008... https://github.com/vuejs/vue-jest/releases/tag/v28.1.0

@Aaron-Pool
Copy link

It's out. Thanks all, especially @nogic1008... https://github.com/vuejs/vue-jest/releases/tag/v28.1.0

And thank you, sir, for getting back to me so quickly 👏

@Theiaz Theiaz mentioned this pull request Aug 18, 2022
Closed
@RhodeHummel RhodeHummel mentioned this pull request Aug 29, 2022
Closed
@nogic1008 nogic1008 deleted the chore/remove-ts-jest branch August 29, 2022 23:36
thebanjomatic pushed a commit to thebanjomatic/vue-jest that referenced this pull request Oct 11, 2022
fix(tsconfig): parse extended tsconfigs when transpiling script blocks
b22b511 
A change introduced in v28.1.0 in PR vuejs#471 unintentionally changed the behavior of the tsconfig parsing such that configs using "extends" were no longer being considered.

Fixes: vuejs#495
thebanjomatic pushed a commit to thebanjomatic/vue-jest that referenced this pull request Oct 11, 2022
fix(tsconfig): parse extended tsconfigs when transpiling script blocks
b191a55 
A change introduced in v28.1.0 in PR vuejs#471 unintentionally changed the behavior of the tsconfig parsing such that configs using "extends" were no longer being considered.

Fixes: vuejs#495
@thebanjomatic thebanjomatic mentioned this pull request Oct 11, 2022
Merged
thebanjomatic pushed a commit to thebanjomatic/vue-jest that referenced this pull request Oct 11, 2022
fix(tsconfig): parse extended tsconfigs when transpiling script blocks
e7f4571 
A change introduced in v28.1.0 in PR vuejs#471 unintentionally changed the behavior of the tsconfig parsing such that configs using "extends" were no longer being considered.

Fixes: vuejs#495
thebanjomatic pushed a commit to thebanjomatic/vue-jest that referenced this pull request Oct 11, 2022
fix(tsconfig): parse extended tsconfigs when transpiling script blocks
fe6745c 
A change introduced in v28.1.0 in PR vuejs#471 unintentionally changed the behavior of the tsconfig parsing such that configs using "extends" were no longer being considered.

Fixes: vuejs#495
thebanjomatic pushed a commit to thebanjomatic/vue-jest that referenced this pull request Nov 1, 2022
fix(tsconfig): parse extended tsconfigs when transpiling script blocks
0fb2493 
A change introduced in v28.1.0 in PR vuejs#471 unintentionally changed the behavior of the tsconfig parsing such that configs using "extends" were no longer being considered.

Fixes: vuejs#495
lmiller1990 pushed a commit that referenced this pull request Nov 3, 2022
@thebanjomatic
fix: parse extended tsconfigs when transpiling script blocks (#502)
bb516da 
* fix(tsconfig): parse extended tsconfigs when transpiling script blocks

A change introduced in v28.1.0 in PR #471 unintentionally changed the behavior of the tsconfig parsing such that configs using "extends" were no longer being considered.

Fixes: #495

* chore(cache): cache tsconfig parsing to avoid the cost per vue file / interpolated string

Co-authored-by: Adam Hines <ahines@factset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990

Assignees

@nogic1008 nogic1008

Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails on lack of ts-jest even though it's optional tsConfig option doesn't work
3 participants
@nogic1008 @lmiller1990 @Aaron-Pool