Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow manually specifying whether server-rendering is targeted #1764

Merged
merged 1 commit into from Nov 30, 2020

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Nov 27, 2020

This option provides a possible fix for #1734

When testing with mocha + mochapack, even though the target
environment is node, the compiled component is expected to be run
with jsdom rather than with a Node.js server, so it should still be
a client bundle.

This option provides a solution for vuejs#1734

When testing with mocha + mochapack, even though the target
environment is `node`, the compiled component is expected to be run
with `jsdom` rather than with a Node.js server, so it should still be
a client bundle.
@sodatea sodatea changed the title feat: allow manual specifying whether server-rendering is targeted feat: allow manualyl specifying whether server-rendering is targeted Nov 30, 2020
@sodatea sodatea merged commit 9bbb82b into vuejs:next Nov 30, 2020
@sodatea sodatea deleted the feat-override-mocha branch November 30, 2020 02:30
@sodatea sodatea changed the title feat: allow manualyl specifying whether server-rendering is targeted feat: allow manually specifying whether server-rendering is targeted Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant