Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll when going back to initial route #1586

Merged
merged 2 commits into from Oct 11, 2017
Merged

Fix scroll when going back to initial route #1586

merged 2 commits into from Oct 11, 2017

Conversation

hworld
Copy link
Contributor

@hworld hworld commented Jul 11, 2017

Should fix: #1585

I added a new e2e test that sets scrollRestoration to manual. Without the fix the test correctly fails.

posva
posva reviewed Jul 23, 2017
View reviewed changes
Copy link
Member

@posva posva left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fix on Firefox and the bug is still happening though... I thought you used dev but you created a new branch 👍

posva
posva approved these changes Jul 23, 2017
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually as well
@yyx990803 I cannot see anything else, can you take a look? (1 line bug fix for Firefox)

@posva
Copy link
Member

posva commented Aug 16, 2017

ping @yyx990803

@yyx990803 yyx990803 merged commit c166822 into vuejs:dev Oct 11, 2017
@djune
Copy link

djune commented Nov 15, 2017 •
edited

@hworld
Throw an exception use IE9 test
// Fix for #1585 for Firefox window.history.replaceState({ key: getStateKey() }, '');

image

@JounQin
Copy link
Contributor

JounQin commented Nov 15, 2017

@djune It has been fixed in #1835 which has not been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrollBehavior doesn't work for initial route in Firefox
5 participants
@hworld @posva @djune @JounQin @yyx990803