Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade path-to-regexp to v1.8.0 (fix #2924) #3032

Merged
merged 3 commits into from
May 11, 2020

Conversation

pimlie
Copy link
Contributor

@pimlie pimlie commented Nov 18, 2019

See issue #2925 and the commit messages.

The server host configuration commit could be omitted but I'm running Node on a remote docker cluster which means I need to set the host to 0.0.0.0. To be able to run the e2e tests I actually also needed to add 'no-sandbox', 'headless', 'disable-gpu', 'disable-dev-shm-usage' to chromeOptions.args in test/e2e/nightwatch.config.js. Otherwise Chrome wont be able to start in a docker container.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you move the test to a new one and also add a test that checks that case sensitive when the option is specified and that params do not match?

@pimlie
Copy link
Contributor Author

pimlie commented Nov 18, 2019

that checks that case sensitive when the option is specified

Hmm, I dont seem to have access to RouteConfig.caseSensitive in normalizeLocation as that only receives a Route type. Would it be ok to add the normalized pathToRegexpOptions to the RouteRecord type?

@posva
Copy link
Member

posva commented Nov 20, 2019

Ah right, it will need a test using the Router instance instance instead let's cover it that way for the moment

@pimlie
Copy link
Contributor Author

pimlie commented Dec 11, 2019

Unfortunately I am not sure how I can use the Router instance to add a test for 2925. Could you elaborate a bit on what I should do?

@posva posva changed the title chore: upgrade path-to-regexp to v1.8.0 (resolves #2924) chore: upgrade path-to-regexp to v1.8.0 (fix #2924) May 11, 2020
@posva posva merged commit f8c6ac1 into vuejs:dev May 11, 2020
@posva
Copy link
Member

posva commented May 11, 2020

I forgot about this one! I locally added a new test. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants