Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error message when component is a promise (fix #3167) #3174

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

better error message when component is a promise (fix #3167) #3174

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
011417b
better error message when component is a promise (fix #3167)
SimonSiefke Apr 16, 2020
1a75110
try to fix failing test
SimonSiefke Apr 16, 2020
f6f0db6
fix: add unit test and update message
SimonSiefke Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/create-route-map.js
View file
Open in desktop
Expand Up @@ -70,6 +70,14 @@ function addRouteRecord (
path || name
)} cannot be a ` + `string id. Use an actual component instead.`
)
if (route.component && route.component.toString) {
assert(
route.component.toString() !== '[object Promise]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check for then in case of poly fills like at https://github.com/vuejs/vue-router-next/blob/master/src/navigationGuards.ts#L171

`route config "component" for path: ${String(
path || name
)} cannot be a promise. Use a function that returns a promise instead (e.g. \`() => import ('./components/About.vue')\`)`
)
}
}

const pathToRegexpOptions: PathToRegexpOptions =
Expand Down