Static matcher #3713
Static matcher #3713
Conversation
|
✔️ Deploy Preview for vue-router-docs-v3 canceled. 🔨 Explore the source changes: 5b6ed7c 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-router-docs-v3/deploys/6202c17babf9d10007f81c8d |
|
The failing test is #3714. |
| @@ -61,9 +61,7 @@ describe('Creating Route Map', function () { | |||
| '', | |||
| '/foo', | |||
| '/bar/', | |||
| '/bar', | |||
There was a problem hiding this comment.
These should still work. Were they removed by accident?
There was a problem hiding this comment.
I removed because the previous rule always match before, the strict flag is false by default.
I was not convinced about this behavior, so I wrote a test to validate it.
https://github.com/buserbrasil/vue-router/commit/c247c520d121b4847d0e9d88db5368885e5bd931
I think it is an implementation detail and don't change any behavior.
It is possible to maintain them in the list, but I have to think how to do it without increasing the size.
There was a problem hiding this comment.
My change remove static rules that will never match because you have another rule matching before. This way I can trust if it exists in path map, it should be used instead of running through the matching loop.
There was a problem hiding this comment.
yeah, these need to be added back, allowing a trailing slash when strict is false is necessary. If you think this is too much, that's fine, it's better to drop these changes on v3
There was a problem hiding this comment.
I changed the test to assert that the parent route is not removed from the list when child route is strict. It don't change matching behavior.
/bar was not removed because /bar/ is strict, but /bar-redirect will never be reached, so it was removed.
I'm ok if it is not merged and I'll work on v3 soon to avoid O(n) matches.
Improves #3709.