fix: ignore non-vue wrapper for auto-destroy (#1723)

Co-authored-by: Joeri Hendrickx <joeri.hendrickx@unleashed.be>
vuejs · Oct 31, 2020 · c198d19 · c198d19
1 parent e1c2526
commit c198d19
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/packages/test-utils/src/auto-destroy.js b/packages/test-utils/src/auto-destroy.js
@@ -21,9 +21,9 @@ export function enableAutoDestroy(hook: (() => void) => void) {
   hook(() => {
     wrapperInstances.forEach((wrapper: Wrapper) => {
       // skip child wrappers created by wrapper.find()
-      if (wrapper.selector) return
-
-      wrapper.destroy()
+      if (wrapper.vm || wrapper.isFunctionalComponent) {
+        wrapper.destroy()
+      }
     })
 
     wrapperInstances.length = 0

diff --git a/test/specs/wrapper.spec.js b/test/specs/wrapper.spec.js
@@ -1,7 +1,8 @@
 import { describeWithShallowAndMount } from '~resources/utils'
 import {
   enableAutoDestroy,
-  resetAutoDestroyState
+  resetAutoDestroyState,
+  createWrapper
 } from 'packages/test-utils/src'
 
 describeWithShallowAndMount('Wrapper', mountingMethod => {
@@ -51,5 +52,16 @@ describeWithShallowAndMount('Wrapper', mountingMethod => {
 
       expect(() => enableAutoDestroy(noop)).toThrow()
     })
+
+    it('does not fail when non-Vue wrappers exist', async () => {
+      let hookCallback
+      enableAutoDestroy(callback => {
+        hookCallback = callback
+      })
+
+      createWrapper(document.createElement('div'))
+
+      expect(hookCallback).not.toThrow()
+    })
   })
 })