Fix two bugs in autodestroy #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💪
Op vr 23 okt. 2020 11:28 schreef Pieter De Decker <notifications@github.com
…:
My colleague @Kjoep <https://github.com/Kjoep> did some bugfixes. I'm
filling out the form on his behalf to get it integrated upstream.
*What kind of change does this PR introduce?* (check at least one)
- Bugfix
- Feature
- Code style update
- Refactor
- Build-related changes
- Other, please describe:
*Does this PR introduce a breaking change?* (check one)
- Yes
- No
If yes, please describe the impact and migration path for existing
applications:
*The PR fulfills these requirements:*
- It's submitted to the dev branch.
- When resolving a specific issue, it's referenced in the PR's title
(e.g. fix #xxx[,#xxx], where "xxx" is the issue number) - *It's not
related to an existing issue thread as far as we know*
- All tests are passing:
https://github.com/vuejs/vue-test-utils/blob/dev/.github/CONTRIBUTING.md#development-setup
- *Awaiting build*
- New/updated tests are included - *The TypeScript change is not
testable. Anything else the author should cover?*
*Other information:*
------------------------------
You can view, comment on, or merge this pull request online at:
#1723
Commit Summary
- fix: ignore non-vue wrapper for auto-destroy
- fix: expose enableAutoDestroy to typescript
File Changes
- *M* packages/test-utils/dist/vue-test-utils.js
<https://github.com/vuejs/vue-test-utils/pull/1723/files#diff-84e0314b904652c9d7d6721189693e86869f5f4e914ac662c1bc5726c1b7cb4b>
(10)
- *M* packages/test-utils/src/auto-destroy.js
<https://github.com/vuejs/vue-test-utils/pull/1723/files#diff-743f1c913e64fdaa9376329cfe2aaf7a2a63fa84b300fe7ed9215ffa647df5c1>
(6)
- *M* packages/test-utils/types/index.d.ts
<https://github.com/vuejs/vue-test-utils/pull/1723/files#diff-295b12b9a221a7aa6d6d3ac9cbbe732796c98f1be23295e31bf7a56d47332712>
(2)
Patch Links:
- https://github.com/vuejs/vue-test-utils/pull/1723.patch
- https://github.com/vuejs/vue-test-utils/pull/1723.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1723>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABV6DDFMYH2HH3DDEUBQ55TSMFECVANCNFSM4S4J4FBQ>
.
|
|
Hi! Thanks for this 🙌 Could you add some unit test to assert that the expected behavior is actually happening? |
|
@afontcu Added a unit test - this one fails without the fix, but succeeds now. |
lmiller1990
reviewed
Oct 30, 2020
| @@ -11223,12 +11223,12 @@ function enableAutoDestroy(hook) { | |||
| isEnabled = true; | |||
|
|
|||
| hook(function () { | |||
| wrapperInstances.forEach(function (wrapper) { | |||
| wrapperInstances.forEach((wrapper) => { | |||
There was a problem hiding this comment.
can you revert this? we only update dist when we do a release
There was a problem hiding this comment.
Done, we've reverted the code change.
|
We've also removed the second commit since it was obsolete after #1724 got merged: |
|
I'll release in the next day or two, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My colleague @Kjoep did some bugfixes. I'm filling out the form on his behalf to get it merged into the mainline.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number) - It's not related to an existing issue thread as far as we knowOther information: