Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync mode cleanup #1671

Merged
merged 3 commits into from Sep 10, 2020
Merged

Sync mode cleanup #1671

merged 3 commits into from Sep 10, 2020

Conversation

AtofStryker
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Update tests, where applicable, to be awaited. This includes trigger, setValue, setSelected,
setProps, setData, setChecked
@lmiller1990 lmiller1990 self-requested a review August 29, 2020 10:43
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still "draft". do you intend to add something else?

The changes seem pretty standard... no problem here.

@AtofStryker
Copy link
Contributor Author

@lmiller1990 I actually forgot about this 😆 . I will likely do another audit of this but I think these changes were the bulk of it. Is there anything in particular we should be looking at when cleaning up sync mode?

@lmiller1990
Copy link
Member

lmiller1990 commented Sep 10, 2020

@AtofStryker no idea - I think most of the sync mode stuff is gone now, I haven't thought about it in a long time.

We could just merge this up now and then I could do a release with your new config handle feature and whatever else has bee merged in lately. what do you think?

@AtofStryker
Copy link
Contributor Author

@lmiller1990 Sounds like a solid plan to me! If I find anything missed while cleaning up, opening another PR is always an option 🙂

@AtofStryker AtofStryker marked this pull request as ready for review September 10, 2020 03:32
@lmiller1990 lmiller1990 merged commit bd91c9f into vuejs:dev Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants