Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the wrapper.getComponent method and corresponding documents. #1714

Merged
merged 6 commits into from
Oct 14, 2020

Conversation

TinyWisp
Copy link
Contributor

@TinyWisp TinyWisp commented Oct 13, 2020

Closes #1711

feat: add the wrapper.getComponent method
docs: create the /docs/api/wrapper/getComponent.md, and add the deprecation message to the /docs/api/wrapper/get.md
docs(zh): create the /docs/zh/api/wrapper/getComponent.md, and add the deprecation message to the /docs/zh/api/wrapper/get.md

docs: create the /docs/api/wrapper/getComponent.md, and add the deprecation message to the /docs/api/wrapper/get.md
docs(zh): create the /docs/zh/api/wrapper/getComponent.md, and add the deprecation message to the /docs/zh/api/wrapper/get.md
Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just suggested a small tweak (in several files, but a single tweak after all!) that bitten us in the past :)

packages/test-utils/src/wrapper.js Outdated Show resolved Hide resolved
docs/api/wrapper/getComponent.md Outdated Show resolved Hide resolved
docs/zh/api/wrapper/getComponent.md Outdated Show resolved Hide resolved
docs/zh/api/wrapper/getComponent.md Outdated Show resolved Hide resolved
docs/api/wrapper/getComponent.md Outdated Show resolved Hide resolved
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to make the recommended changes, and I will release this. Thanks!

TinyWisp and others added 5 commits October 14, 2020 08:36
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
@lmiller1990 lmiller1990 merged commit c90f597 into vuejs:dev Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants