fix(create-local-vue): fix max range stack size (fix #1768) #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this PR is expected to fail, it seems that every checks are green which is quite confusing. 🤔 😁 |
lmiller1990
reviewed
Feb 11, 2021
test/specs/create-local-vue.spec.js
Outdated
| const sets = Array.from({ length: 2 }) | ||
|
|
||
| it.each(sets)( | ||
| // Note, the message may not be the final one, based on what I discover. |
There was a problem hiding this comment.
can you put link to the issue? it will be difficult to remember what this test is really doing
antoinerey
force-pushed
the
fix/issue-1768
branch
from
0e80f99
to
be6a882
Compare
antoinerey
changed the title
|
Let's hope this does not break anything 👀 |
|
@lmiller1990 what's the release schedule for the project like? When do you think we'll see this fix released into the wild? |
|
There is no set schedule, it's just whenever I do one. I can do a release this week. Maybe we should investigate sem-release and automate things... If no release within a few days, ping me again, but I should be able to do it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)Other information: