Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-utils): add type definitions for ExtendedVue #1789

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

yshrsmz
Copy link
Contributor

@yshrsmz yshrsmz commented Feb 15, 2021

add mount & shallowMount type definitions for ExtendedVue, return type of Vue.extend() method

this fixes #1781

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

add mount & shallowMount type definitions for ExtendedVue, return type of Vue.extend() method

this fixes vuejs#1781
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lmiller1990 lmiller1990 merged commit 980434b into vuejs:dev Feb 24, 2021
@yshrsmz yshrsmz deleted the mount-types branch February 24, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error with functional component
2 participants