Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly find functional components #1835

Merged
merged 2 commits into from
Apr 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/test-utils/src/matches.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,14 @@ export function matches(node, selector) {
return element && element.matches && element.matches(selector.value)
}

const componentInstance = node[FUNCTIONAL_OPTIONS] || node.child
const isFunctionalSelector = isConstructor(selector.value)
? selector.value.options.functional
: selector.value.functional

const componentInstance =
(isFunctionalSelector ? node[FUNCTIONAL_OPTIONS] : node.child) ||
node[FUNCTIONAL_OPTIONS] ||
node.child

if (!componentInstance) {
return false
Expand Down
2 changes: 1 addition & 1 deletion test/specs/create-local-vue.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describeWithShallowAndMount('createLocalVue', mountingMethod => {
})

itDoNotRunIf(
mountingMethod.name === 'shallowMount',
mountingMethod.name === 'shallowMount' || vueVersion < 2.6,
'Router should work properly with local Vue',
async () => {
const localVue = createLocalVue()
Expand Down
55 changes: 54 additions & 1 deletion test/specs/wrapper/find.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { compileToFunctions } from 'vue-template-compiler'
import { createLocalVue } from 'packages/test-utils/src'
import { createLocalVue, shallowMount } from 'packages/test-utils/src'
import Vue from 'vue'
import VueRouter from 'vue-router'
import ComponentWithChild from '~resources/components/component-with-child.vue'
import ComponentWithoutName from '~resources/components/component-without-name.vue'
import ComponentWithSlots from '~resources/components/component-with-slots.vue'
Expand All @@ -17,6 +18,58 @@ import {
import { itDoNotRunIf, itSkipIf } from 'conditional-specs'

describeWithShallowAndMount('find', mountingMethod => {
itDoNotRunIf(
mountingMethod.name === 'shallowMount',
'returns a VueWrapper using a <router-view /> component',
async () => {
const localVue = createLocalVue()
localVue.use(VueRouter)
const TestComponentToFind = {
render: h => h('div'),
name: 'test-component-to-find'
}
const routes = [
{
path: '/a/b',
name: 'ab',
component: TestComponentToFind
}
]
const router = new VueRouter({ routes })
const wrapper = mountingMethod(
{
template: '<router-view/>'
},
{
localVue,
router
}
)

await router.push('/a/b')

expect(wrapper.findComponent(TestComponentToFind).exists()).toBe(true)
}
)

it('findComponent in functional component', () => {
const Comp2 = {
name: 'test',
render(h) {
return h('div', 'test')
}
}
const Comp = {
name: 'Comp',
functional: true,
render(h) {
return h(Comp2)
}
}
const wrapper = shallowMount(Comp)
wrapper.getComponent(Comp2)
})

it('returns a Wrapper matching tag selector passed', () => {
const compiled = compileToFunctions('<div><p></p><p></p></div>')
const wrapper = mountingMethod(compiled)
Expand Down