docs(test-utils): add tip about using trigger('focus')
#1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lmiller1990 follow-up to #1777. Can you take a look at this when you have time? |
lmiller1990
reviewed
May 20, 2021
docs/api/wrapper/trigger.md
Outdated
| @@ -38,6 +38,10 @@ test('trigger demo', async () => { | |||
| }) | |||
| ``` | |||
|
|
|||
| ::: tip | |||
| When using `trigger('focus')` with [jsdom v16.4.0](https://github.com/jsdom/jsdom/releases/tag/16.4.0) and above you must use the [attachTo](../options.md#attachto) option when mounting the component. This is because `el.focus()` does not work on elements that are disconnected from the DOM. | |||
There was a problem hiding this comment.
Is this a bug in versions of jsdom earlier or later than 16.4.0? Might be good to specify.
There was a problem hiding this comment.
@lmiller1990 It looks like jsdom does consider this change a bug fix. I have updated the tip text to say:
When using `trigger('focus')` with [jsdom v16.4.0](https://github.com/jsdom/jsdom/releases/tag/16.4.0) and above you must use the [attachTo](../options.md#attachto) option when mounting the component. This is because a bug fix in [jsdom v16.4.0](https://github.com/jsdom/jsdom/releases/tag/16.4.0) changed `el.focus()` to do nothing on elements that are disconnected from the DOM.WDYT?
When using `trigger('focus')` with jsdom v16.4.0 and above you must
use `attachTo` when mounting the component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1777 (comment) this PR adds a tip to the documentation about how
attachTois needed when usingtrigger('focus')with jsdom v16.4.0 and aboveWhat kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
#1777 (comment)