Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selectors.md #2088

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update selectors.md #2088

wants to merge 1 commit into from

Conversation

skillsnate
Copy link

Added a component example, with a template, to make it clear how the selectors can work

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
  • Documentation modification

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Added a component example, with a template, to make it clear how the selectors can work
Copy link

netlify bot commented Jan 1, 2024

Deploy Preview for vue-test-utils-v1 ready!

Name Link
🔨 Latest commit ca5a68b
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-v1/deploys/659341998d692d00086b902f
😎 Deploy Preview https://deploy-preview-2088--vue-test-utils-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skillsnate
Copy link
Author

I have added two different ways to define the component, and I wasn't sure which one would be preferred. The main point I was trying to clarify was how the ref and name selectors can be used to select elements, with an example. Totally understand if this is too different to other testing documentation and not needed. While I'm getting more into the vue testing space, I found a bit of confusion here and thought an example would help 👍

@skillsnate
Copy link
Author

The failed CI test looks to be related to code styling, for 7 pages, One of them I have modified. Pulling the docker image and running the prettier to determine what's wrong with the styling to fix it

@skillsnate
Copy link
Author

Unfortunately I can't find the project files in the docker image, I suspect they're added as part of the implementation details in CircleCI's 'attaching workspace' step. I haven't setup this project locally, just changed the file in github's editor. If it's needed I can set it up locally, but I don't want to spend more time on this, unless someone from vuejs can let me know if it's worth it.

So I guess, bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant