Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not deep merge array data in setData #604

Merged
merged 1 commit into from
May 14, 2018
Merged

fix: Do not deep merge array data in setData #604

merged 1 commit into from
May 14, 2018

Conversation

lchanmann
Copy link
Contributor

What went wrong?

In #565, we do a deep merge on Object data however if the data is an array deep merge would mutate the data so vm.$set would have no effect.

The typeof operator is kind of inconsistent (i.e. typeof [] === 'object') and we need also array checking to avoid deep merge array data.

@lchanmann
Copy link
Contributor Author

ping @shortdiv, @eddyerburgh

@lchanmann lchanmann mentioned this pull request May 14, 2018
Closed
eddyerburgh
eddyerburgh approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@eddyerburgh eddyerburgh merged commit 934745b into vuejs:dev May 14, 2018
@lchanmann
Copy link
Contributor Author

TY

@lchanmann lchanmann deleted the fix-setData branch May 15, 2018 13:52
@eddyerburgh eddyerburgh mentioned this pull request May 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lchanmann @eddyerburgh