Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(warns): avoid warning native modifiers on dynamic components #11052

Merged
merged 2 commits into from Mar 30, 2021
Merged

feat(warns): avoid warning native modifiers on dynamic components #11052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b2bd5
do not warn about .native modifier for <component :is=...
andrzejatdiligen Jan 24, 2020
225978c
test for not warning about .native modifier on component tags
andrzejatdiligen Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/vdom/create-element.js
View file
Open in desktop
Expand Up @@ -98,7 +98,7 @@ export function _createElement (
ns = (context.$vnode && context.$vnode.ns) || config.getTagNamespace(tag)
if (config.isReservedTag(tag)) {
// platform built-in elements
if (process.env.NODE_ENV !== 'production' && isDef(data) && isDef(data.nativeOn)) {
if (process.env.NODE_ENV !== 'production' && isDef(data) && isDef(data.nativeOn) && data.tag !== 'component') {
warn(
`The .native modifier for v-on is only valid on components but it was used on <${tag}>.`,
context
Expand Down
14 changes: 14 additions & 0 deletions test/unit/features/directives/on.spec.js
View file
Open in desktop
Expand Up @@ -474,6 +474,20 @@ describe('Directive v-on', () => {
expect(spy.calls.count()).toBe(0)
})

it('should not throw a warning if native modifier is used on a dynamic component', () => {
vm = new Vue({
el,
template: `
<component is="div" @click.native="foo('native')" @click="foo('regular')"/>
`,
methods: { foo: spy },
})

triggerEvent(vm.$el, 'click')
expect(`The .native modifier for v-on is only valid on components but it was used on <div>.`).not.toHaveBeenWarned()
expect(spy.calls.allArgs()).toEqual([['regular']]); // Regular @click should work for dynamic components resolved to native HTML elements.
})

it('.once modifier should work with child components', () => {
vm = new Vue({
el,
Expand Down