Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't normalize scoped slot with 2+ nodes #12103

Closed
wants to merge 1 commit into from
Closed

fix: don't normalize scoped slot with 2+ nodes #12103

wants to merge 1 commit into from

Conversation

caugner
Copy link

@caugner caugner commented Jun 2, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Resolves #12102.

Note that I inlined the local variable vnode (introduced in #11963) again, because IMO it is only used in one of the condition clauses and ultimately may have caused the necessary confusion for this bug to slip through.

Props to @JaviIG for locating the source of the issue.

@posva posva changed the title fix #12102: don't normalize scoped slot with 2+ nodes fix: don't normalize scoped slot with 2+ nodes Jun 2, 2021
@caugner
Copy link
Author

caugner commented Jun 2, 2021

@posva I'm curious why you removed the issue reference from the title, since it's explicitly mentioned as a requirement, or is that outdated? 😄

When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

@posva
Copy link
Member

posva commented Jun 2, 2021

Thanks for this I ended up adding a test and a smaller change: #12104

It seems outdated, yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.6.13] Node after v-if node inside named slot is not shown anymore
2 participants