Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite haschanged fn (#12595) #12602

Closed
wants to merge 1 commit into from
Closed

Conversation

deftliang
Copy link
Contributor

@deftliang deftliang commented Jul 2, 2022

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
fix #12595
util method hasChanged(100, NaN) return false

@deftliang deftliang changed the title fix(#12595): rewrite haschagned fn fix(#12595): rewrite haschanged fn Jul 2, 2022
@deftliang deftliang changed the title fix(#12595): rewrite haschanged fn fix: rewrite haschanged fn (#12595) Jul 3, 2022
@yyx990803
Copy link
Member

The logic should be the reverse of Object.is, not a direct copy. See ff5acb1

@yyx990803 yyx990803 closed this Jul 4, 2022
@deftliang
Copy link
Contributor Author

The logic should be the reverse of Object.is, not a direct copy. See ff5acb1

ths, evan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot assign to a NaN variable
3 participants